Re: [PATCH] sd: Adds flexible disk (TEAC FC-1, scsi-floppy) support to scsi disk driver

On 3/8/2007 1:26 PM, Grant Grundler wrote:
> welcome :)
> kudos for chasing this.

No Problem.  I can't think of anything more exciting than finally getting an
obscure, antiquated, low-capacity, franken-drive like the TEAC FC-1 working.
But seriously, I hope someone else finds this patch useful.

> It sounds good but it's totally not obvious this was the intent.
> If you are "hard coding" the geometry, then can't you just use #define?

Yes or consts, whichever is preferable.  The drive geometry is always initially
incorrect, so I must set it to the correct values.  These values should always
be the same for THIS drive... which leads me to...

> I expect there are other "device->removable && !TYPE_MOD" devices.

You would know this better than I, so I'll defer to you.  I was always a bit
uncomfortable making this assumption, which I documented in a comment in the
code.  When the scsi driver attaches to my devices, they are all of TYPE_DISK
and removable.  I was hoping someone else could test this out with a different
scsi-floppy drive, but there may not be any others.  Would it be a better idea
to use model and vendor information to exactly identify the drive as a TEAC FC-1?

Regards,
James Love