Re: Some warning: ... cleanup; realy no interest?

Kyle McMartin wrote:
> On Fri, Aug 03, 2007 at 11:16:08AM -0400, John David Anglin wrote:
>>>>> /CAD/linux-2.6.22-pa/drivers/parisc/dino.c: In function ?dino_bridge_init?:
>>>>> /CAD/linux-2.6.22-pa/drivers/parisc/dino.c:821: warning: format %lx
>>> expects type long unsigned int, but argument 4 has type 
>>>>> resource_size_t
>>>>> /CAD/linux-2.6.22-pa/drivers/parisc/dino.c:821: warning: format %lx
>>> expects type long unsigned int, but argument 5 has type 
>>>>> resource_size_t
>> >From linux/types.h:
>>
>> #ifdef CONFIG_RESOURCES_64BIT
>> typedef u64 resource_size_t;
>> #else
>> typedef u32 resource_size_t;
>> #endif
>>
>> %lx looks right for parisc.  This is ugly but you can kill the warning
>> by casting arguments 4 and 5 to unsigned long.
>>
> 
> We're "supposed" to use %llx and cast to a ULL, this is because of
> CONFIG_RESOURCES_64BIT which is for crap architectures which have
> 32-bit registers, but the possibility of bigger physical addresses,
> (think i386 with 36-bit PAE addressing.)
> 
> --Kyle
> 
> 
mmm and what do you think about adding yet another format letter e.g. [rR] for resource_size_t as it was done for [zZ]?

Tia,
	j.