Re: [patch 2/2] backport of sba sg list management to ccio-dma

Joel Soete wrote:
 >
 >
[snip]
 >
 > so I need to be sure that the value of ((size - 1) >> (PAGE_SHIFT))
 > would always stand in a int (not unsigned but sign) for 32bit (iirc
 > size_of(unsigned long)==32) and 64bit (size_of(unsigned long)==64)
 > implementations?
 >
Definitely not:

if ul = 0xffffffffffffffff (64bit wide i.e. 16*4bits)
ul >> 12 (PAGE_SHIFT) == 0xfffffffffffff (13*4bits)

and INT_MAX= 0x7fffffff far well < then 0xfffffffffffff ;_(

we can get the idea in a corner when fls prototype will change.

Sorry,
	J.