Re: [patch 2/2] backport of sba sg list management to ccio-dma

Joel Soete wrote:
> Grant,
> 
> 
> Grant Grundler wrote:
>> On Sun, Oct 28, 2007 at 02:45:24PM +0000, Joel Soete wrote:
>> ...
>>> e.g.
>>> # more GetOrder-poc.c
>> ...
>>> give me well same results:
>>> # ./GetOrder-poc
>>> get_order(1) = 0 (0x0);
>>> get_order_poc(1) = 0 (0x0).
>> ...
>>
>> Good!
>>
>> ...
>>> But I need to check more on a detail:
>>> here is the prototype of fls():
>>> static inline int fls(int x)
>>>
>>> so I need to be sure that the value of ((size - 1) >> (PAGE_SHIFT)) 
>>> would always stand in a int (not unsigned but sign) for 32bit (iirc 
>>> size_of(unsigned long)==32) and 64bit (size_of(unsigned long)==64) 
>>> implementations?
>>
>> Huh?
>> Why do you care how (unsigned long) is handled when the function 
>> prototype
>> defines the API to pass in an "int"?
>>
it seems that I simply forget the existance of fls_long().

I can now safely patch get_order() ;<).

Tx,
	J.

PS: Yes DELAYED_RESOURCE_CNT was set to 16