Re: [PATCH v4 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer()
Javier Martinez Canillas <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.kernel.cross-arch,gmane.linux.ports.ia64,gmane.linux.ports.mips,gmane.comp.video.dri.devel,gmane.linux.ports.sparc |
|---|---|
| Message-ID | <[email protected]> |
Thomas Zimmermann <[email protected]> writes: Hello Thomas, > Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer(). > The helper sets VMA page-access flags for framebuffers in device I/O > memory. > I think this rename makes it more clear. > Also clean up the helper's parameters and return value. Instead of > the VMA instance, pass the individial parameters separately: existing > page-access flags, the VMAs start and end addresses and the offset But I fail to see the benefit of this part. Could you please add an explanation about why this change is desirable ? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat