Re: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init()

Gavin Shan <[email protected]> Mon, 13 Nov 2023 10:58:46 +1000

Newsgroups	gmane.linux.acpi.devel,gmane.linux.power-management.general,gmane.linux.kernel.cross-arch,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.riscv,gmane.linux.documentation,gmane.linux.ports.ia64,gmane.linux.ports.parisc
Message-ID	<[email protected]>


On 11/7/23 20:30, Russell King (Oracle) wrote:
> From: James Morse <[email protected]>
> 
> NUMA systems require the node descriptions to be ready before CPUs are
> registered. This is so that the node symlinks can be created in sysfs.
> 
> Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs
> are registered by arch code, instead of cpu_dev_init().
> 
> Move cpu_dev_init() after node_dev_init() so that NUMA architectures
> can use GENERIC_CPU_DEVICES.
> 
> Signed-off-by: James Morse <[email protected]>
> Signed-off-by: Russell King (Oracle) <[email protected]>
> ---
> Note: Jonathan's comment still needs addressing - see
>    https://lore.kernel.org/r/[email protected]
> ---
>   drivers/base/init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

With Jonathan's comments addressed:

Reviewed-by: Gavin Shan <[email protected]>