Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int
Tianyu Lan <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.comp.emulators.kvm.arm.devel,gmane.linux.ports.mips.general,gmane.comp.emulators.kvm.powerpc.devel,gmane.linux.ports.ppc64.devel,gmane.comp.emulators.kvm.devel |
|---|---|
| Message-ID | <CAOLK0pyKsS2hLagZ6pumMdfRokPig2P+KJambVOq7p+NU-OqgA@mail.gmail.com> |
Hi Paul:
Thanks for your review.
On Wed, Dec 12, 2018 at 1:03 PM Paul Mackerras <[email protected]> wrote:
>
> On Thu, Dec 06, 2018 at 09:21:10PM +0800, [email protected] wrote:
> > From: Lan Tianyu <[email protected]>
> >
> > The patch is to make kvm_set_spte_hva() return int and caller can
> > check return value to determine flush tlb or not.
>
> It would be helpful if the patch description told the reader which
> return value(s) mean that the caller should flush the tlb. I would
> guess that non-zero means to do the flush, but you should make that
> explicit.
OK. Thanks for suggestion and will update in the next version.
>
> > Signed-off-by: Lan Tianyu <[email protected]>
>
> For the powerpc bits:
>
> Acked-by: Paul Mackerras <[email protected]>
--
Best regards
Tianyu Lan