Re: [PATCH 0/2] watchdog: mtx-1: Relax build dependencies
Guenter Roeck <[email protected]> Wed, 11 Dec 2019 17:39:41 -0800
| Newsgroups | gmane.linux.kernel,gmane.linux.watchdog,gmane.linux.ports.mips.general |
|---|---|
| Message-ID | <[email protected]> |
On 12/11/19 3:46 PM, Denis Efremov wrote: > Hi, > > Thanks for the fix. > I tested the compilation with these patches. > You can add my: > Tested-by: Denis Efremov <[email protected]> > > Look like this error could be fixed the same way: > In file included from drivers/watchdog/ar7_wdt.c:29: > ./arch/mips/include/asm/mach-ar7/ar7.h: In function ‘ar7_is_titan’: > ./arch/mips/include/asm/mach-ar7/ar7.h:111:24: error: implicit declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’? [-Werror=implicit-function-declaration] > This is yet another old-style watchdog driver which should be left alone unless it has a bug that needs to be fixed. Really, if anyone out there is still using this driver, converting it to use the watchdog core would make much more sense. Guenter