[PATCH 4.4 029/312] MIPS: Octeon: Off by one in octeon_irq_gpio_map()
Greg Kroah-Hartman <[email protected]> Fri, 8 May 2020 14:30:20 +0200
| Newsgroups | gmane.linux.kernel.janitors,gmane.linux.kernel,gmane.linux.kernel.stable,gmane.linux.ports.mips.general |
|---|---|
| Message-ID | <[email protected]> |
From: Dan Carpenter <[email protected]> commit 008d0cf1ec69ec6d2c08f2d23aff2b67cbe5d2af upstream. It should be >= ARRAY_SIZE() instead of > ARRAY_SIZE(). Fixes: 64b139f97c01 ('MIPS: OCTEON: irq: add CIB and other fixes') Signed-off-by: Dan Carpenter <[email protected]> Acked-by: David Daney <[email protected]> Cc: Rob Herring <[email protected]> Cc: Marc Zyngier <[email protected]> Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/13813/ Signed-off-by: Ralf Baechle <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> --- arch/mips/cavium-octeon/octeon-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/mips/cavium-octeon/octeon-irq.c +++ b/arch/mips/cavium-octeon/octeon-irq.c @@ -1220,7 +1220,7 @@ static int octeon_irq_gpio_map(struct ir line = (hw + gpiod->base_hwirq) >> 6; bit = (hw + gpiod->base_hwirq) & 63; - if (line > ARRAY_SIZE(octeon_irq_ciu_to_irq) || + if (line >= ARRAY_SIZE(octeon_irq_ciu_to_irq) || octeon_irq_ciu_to_irq[line][bit] != 0) return -EINVAL;