Re: [PATCH 1/4] powerpc/pseries: Limit PVR list to 16 entries for CAS negotiation

Mahesh J Salgaonkar <[email protected]> Mon, 3 Aug 2026 10:16:24 +0530

Newsgroups	gmane.linux.ports.ppc.embedded
Message-ID	<anAc201oMWHrU2Ld__11228.3879936271$1785732406$gmane$org@linux.ibm.com>

On 2026-08-03 08:52:24 Mon, Nikhil Kumar Singh wrote:
> 
> 
> On 29/07/26 20:24, Mahesh Salgaonkar wrote:
> 
> > +	if ((ARRAY_SIZE(ibm_architecture_vec_template.pvrs) > 16) &&
> > +	    (PVR_VER(mfspr(SPRN_PVR)) <= PVR_POWER11))
> > +		start_index = ARRAY_SIZE(ibm_architecture_vec_template.pvrs) - 16;
> 
> 
> 
> Hi Mahesh,
> 
> The literal 16 appears twice. Please define a named macro,
> e.g.: #define CAS_MAX_PVR_ENTRIES 16

Sure, will do. Thanks for your review.

Thanks,
-Mahesh.
> 
> Thanks,
> ~ Nikhil
> 

-- 
Mahesh J Salgaonkar