[PATCH] ASoC: fsl_easrc: fix missing return on success in runtime_resume
| Newsgroups | gmane.linux.ports.ppc.embedded |
|---|---|
| Message-ID | <20260807072202.380021-1-shengjiu.wang__30623.7793107115$1786086992$gmane$org@oss.nxp.com> |
From: Shengjiu Wang <[email protected]> Commit 48d84310be60 ("ASoC: fsl_easrc: Use guard() for spin locks") refactored fsl_easrc_runtime_resume() but accidentally dropped the early return on the success path. The original code had a skip_load label followed by "return 0"; that label was removed during cleanup but the corresponding success return was lost too. As a result, every successful resume falls through into the disable_mem_clk error path and calls clk_disable_unprepare() on a clock that is still in use, leading to an unbalanced clock disable. Restore the missing "return 0" before the disable_mem_clk error label. Fixes: 48d84310be60 ("ASoC: fsl_easrc: Use guard() for spin locks") Signed-off-by: Shengjiu Wang <[email protected]> --- sound/soc/fsl/fsl_easrc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index 17d85d484358..2ac062083782 100644 --- a/sound/soc/fsl/fsl_easrc.c +++ b/sound/soc/fsl/fsl_easrc.c @@ -2425,6 +2425,7 @@ static int fsl_easrc_runtime_resume(struct device *dev) goto disable_mem_clk; } + return 0; disable_mem_clk: clk_disable_unprepare(easrc->mem_clk); return ret; -- 2.34.1