Re: [PATCH v2] powerpc: remove dead 440SP code
Julian Braha <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.kernel.janitors,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 9/1/26 16:28, Frank Li wrote:
> On Tue, Sep 01, 2026 at 04:06:45PM +0100, Julian Braha wrote:
>> The 440SP config option can never be enabled, making all references to it
>> dead code.
>>
>> The only board using CONFIG_440SP was IBM LUAN, which was commented out by
>> commit f65573314e4e ("[POWERPC] Re-organize Kconfig code for 4xx in
>> arch/powerpc") then removed by commit ff5f483f3091 ("powerpc: 4xx: remove
>> commented out Kconfig entries").
>>
>> Let's remove support for 440SP, since nobody can be using it anyway.
>>
>> This dead code was found by kconfirm, a static analysis tool for Kconfig.
>>
>> Signed-off-by: Julian Braha <[email protected]>
>> ---
>> Changes since v1:
>> - cleaned up preprocessor condition
>> - added historic details to description
>>
>> Link to v1:
>> https://lore.kernel.org/all/[email protected]/
>> ---
>> arch/powerpc/boot/cuboot-katmai.c | 2 +-
>> arch/powerpc/include/asm/async_tx.h | 2 +-
>> arch/powerpc/include/asm/dcr-regs.h | 10 +++++-----
>> arch/powerpc/kernel/cpu_specs_44x.h | 12 ------------
>> arch/powerpc/platforms/44x/Kconfig | 3 ---
>> drivers/dma/Kconfig | 2 +-
>> drivers/dma/ppc4xx/adma.c | 9 ---------
>> drivers/dma/ppc4xx/adma.h | 2 +-
>> drivers/dma/ppc4xx/dma.h | 9 ---------
>
> Please split for difference subsystem.
Will do in v4, thanks! (v3 was already sent because of a dumb mistake in
amending the commit.)
- Julian Braha