Re: [PATCH 10/11] ppc64: SPU file system

On Freedag 29 Juli 2005 01:57, Geoff Levand wrote:
> Arnd Bergmann wrote:
> ...
> > --- linux-cg.orig/mm/memory.c	2005-06-21 22:48:42.154975624 -0400
> > +++ linux-cg/mm/memory.c	2005-06-21 22:48:48.780899080 -0400
> > @@ -2201,6 +2201,7 @@ unsigned long vmalloc_to_pfn(void * vmal
> >  {
> >  	return page_to_pfn(vmalloc_to_page(vmalloc_addr));
> >  }
> > +EXPORT_SYMBOL_GPL(handle_mm_fault);
> >  
> >  EXPORT_SYMBOL(vmalloc_to_pfn);
> >  
>  
> Your change to handle_mm_fault causes problems when I build for Ebony (ppc32).
> 
>   mm/built-in.o(*ABS*+0xfe6822c0): In function `__crc_handle_mm_fault':
>   shmem.c: multiple definition of `__crc_handle_mm_fault'
>   make[1]: *** [.tmp_vmlinux1] Error 1
> 
>   $ egrep -HRn 'EXPORT_SYMBOL(_GPL)?\(handle_mm_fault' .
>   ./mm/memory.c:2208:EXPORT_SYMBOL_GPL(handle_mm_fault);
>   ./arch/ppc/kernel/ppc_ksyms.c:329:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */

Right, good catch. The simple solution would be to remove the
EXPORT_SYMBOL from arch/ppc/kernel/ppc_ksyms.c. Can anyone from
MOL comment on wether it is ok for you to have it exported
GPL-only?
 
> Also, it seems a definition of the DEFINE_SIMPLE_ATTRIBUTE macro is missing. 
> Did I miss one of your patches? 

It was merged in 2.6.13-rc. An earlier version of the patch that might
still work on vanilla 2.6.12 is at 
http://patchwork.ozlabs.org/linuxppc64/patch?id=835

	Arnd <><