Re: [PATCH 04/33] mm: add utility functions for ptdesc
kernel test robot <[email protected]>
| Newsgroups | gmane.linux.ports.mips,gmane.linux.kernel.mm,gmane.linux.kernel.cross-arch,gmane.linux.ports.arm.kernel,gmane.linux.ports.hexagon,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.comp.emulators.xen.devel,gmane.comp.emulators.kvm.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Vishal, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on s390/features powerpc/next powerpc/fixes geert-m68k/for-next geert-m68k/for-linus linus/master v6.3-rc7 next-20230417] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vishal-Moola-Oracle/s390-Use-_pt_s390_gaddr-for-gmap-address-tracking/20230418-045832 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230417205048.15870-5-vishal.moola%40gmail.com patch subject: [PATCH 04/33] mm: add utility functions for ptdesc config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230418/[email protected]/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1b6f8137ca50a543ad2937092836635ca58c78ce git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vishal-Moola-Oracle/s390-Use-_pt_s390_gaddr-for-gmap-address-tracking/20230418-045832 git checkout 1b6f8137ca50a543ad2937092836635ca58c78ce # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh prepare If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <[email protected]> | Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All error/warnings (new ones prefixed by >>): In file included from arch/sh/kernel/asm-offsets.c:14: include/linux/mm.h: In function 'virt_to_ptdesc': >> include/linux/mm.h:2723:16: error: implicit declaration of function 'page_ptdesc' [-Werror=implicit-function-declaration] 2723 | return page_ptdesc(virt_to_head_page(x)); | ^~~~~~~~~~~ >> include/linux/mm.h:2723:16: warning: returning 'int' from a function with return type 'struct ptdesc *' makes pointer from integer without a cast [-Wint-conversion] 2723 | return page_ptdesc(virt_to_head_page(x)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from arch/sh/include/asm/thread_info.h:13, from include/linux/thread_info.h:60, from include/asm-generic/preempt.h:5, from ./arch/sh/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:56, from include/linux/mmzone.h:8, from include/linux/gfp.h:7, from include/linux/mm.h:7: include/linux/mm.h: In function 'ptdesc_to_virt': >> include/linux/mm.h:2728:29: error: implicit declaration of function 'ptdesc_page'; did you mean 'pte_page'? [-Werror=implicit-function-declaration] 2728 | return page_to_virt(ptdesc_page(pt)); | ^~~~~~~~~~~ arch/sh/include/asm/page.h:139:27: note: in definition of macro '___va' 139 | #define ___va(x) ((x)+PAGE_OFFSET) | ^ include/linux/mm.h:117:25: note: in expansion of macro '__va' 117 | #define page_to_virt(x) __va(PFN_PHYS(page_to_pfn(x))) | ^~~~ include/linux/mm.h:117:30: note: in expansion of macro 'PFN_PHYS' 117 | #define page_to_virt(x) __va(PFN_PHYS(page_to_pfn(x))) | ^~~~~~~~ include/asm-generic/memory_model.h:64:21: note: in expansion of macro '__page_to_pfn' 64 | #define page_to_pfn __page_to_pfn | ^~~~~~~~~~~~~ include/linux/mm.h:2728:16: note: in expansion of macro 'page_to_virt' 2728 | return page_to_virt(ptdesc_page(pt)); | ^~~~~~~~~~~~ >> include/asm-generic/memory_model.h:46:35: warning: initialization of 'const struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 46 | ({ const struct page *__pg = (pg); \ | ^ arch/sh/include/asm/page.h:139:27: note: in definition of macro '___va' 139 | #define ___va(x) ((x)+PAGE_OFFSET) | ^ include/linux/mm.h:117:25: note: in expansion of macro '__va' 117 | #define page_to_virt(x) __va(PFN_PHYS(page_to_pfn(x))) | ^~~~ include/linux/mm.h:117:30: note: in expansion of macro 'PFN_PHYS' 117 | #define page_to_virt(x) __va(PFN_PHYS(page_to_pfn(x))) | ^~~~~~~~ include/asm-generic/memory_model.h:64:21: note: in expansion of macro '__page_to_pfn' 64 | #define page_to_pfn __page_to_pfn | ^~~~~~~~~~~~~ include/linux/mm.h:117:39: note: in expansion of macro 'page_to_pfn' 117 | #define page_to_virt(x) __va(PFN_PHYS(page_to_pfn(x))) | ^~~~~~~~~~~ include/linux/mm.h:2728:16: note: in expansion of macro 'page_to_virt' 2728 | return page_to_virt(ptdesc_page(pt)); | ^~~~~~~~~~~~ include/linux/mm.h: In function 'ptdesc_address': >> include/linux/mm.h:2733:30: error: implicit declaration of function 'ptdesc_folio'; did you mean 'page_folio'? [-Werror=implicit-function-declaration] 2733 | return folio_address(ptdesc_folio(pt)); | ^~~~~~~~~~~~ | page_folio >> include/linux/mm.h:2733:30: warning: passing argument 1 of 'folio_address' makes pointer from integer without a cast [-Wint-conversion] 2733 | return folio_address(ptdesc_folio(pt)); | ^~~~~~~~~~~~~~~~ | | | int include/linux/mm.h:2151:55: note: expected 'const struct folio *' but argument is of type 'int' 2151 | static inline void *folio_address(const struct folio *folio) | ~~~~~~~~~~~~~~~~~~~~^~~~~ include/linux/mm.h: In function 'ptdesc_is_reserved': >> include/linux/mm.h:2738:36: warning: passing argument 1 of 'folio_test_reserved' makes pointer from integer without a cast [-Wint-conversion] 2738 | return folio_test_reserved(ptdesc_folio(pt)); | ^~~~~~~~~~~~~~~~ | | | int In file included from include/linux/mmzone.h:23: include/linux/page-flags.h:375:62: note: expected 'struct folio *' but argument is of type 'int' 375 | static __always_inline bool folio_test_##lname(struct folio *folio) \ | ~~~~~~~~~~~~~~^~~~~ include/linux/page-flags.h:423:9: note: in expansion of macro 'TESTPAGEFLAG' 423 | TESTPAGEFLAG(uname, lname, policy) \ | ^~~~~~~~~~~~ include/linux/page-flags.h:494:1: note: in expansion of macro 'PAGEFLAG' 494 | PAGEFLAG(Reserved, reserved, PF_NO_COMPOUND) | ^~~~~~~~ include/linux/mm.h: In function 'ptdesc_alloc': include/linux/mm.h:2745:16: warning: returning 'int' from a function with return type 'struct ptdesc *' makes pointer from integer without a cast [-Wint-conversion] 2745 | return page_ptdesc(page); | ^~~~~~~~~~~~~~~~~ include/linux/mm.h: In function 'ptdesc_free': >> include/linux/mm.h:2750:29: warning: initialization of 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 2750 | struct page *page = ptdesc_page(pt); | ^~~~~~~~~~~ include/linux/mm.h: In function 'free_reserved_ptdesc': >> include/linux/mm.h:2988:28: warning: passing argument 1 of 'free_reserved_page' makes pointer from integer without a cast [-Wint-conversion] 2988 | free_reserved_page(ptdesc_page(pt)); | ^~~~~~~~~~~~~~~ | | | int include/linux/mm.h:2971:52: note: expected 'struct page *' but argument is of type 'int' 2971 | static inline void free_reserved_page(struct page *page) | ~~~~~~~~~~~~~^~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:114: arch/sh/kernel/asm-offsets.s] Error 1 make[2]: Target 'prepare' not remade because of errors. make[1]: *** [Makefile:1286: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:226: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/page_ptdesc +2723 include/linux/mm.h 2720 2721 static inline struct ptdesc *virt_to_ptdesc(const void *x) 2722 { > 2723 return page_ptdesc(virt_to_head_page(x)); 2724 } 2725 2726 static inline void *ptdesc_to_virt(struct ptdesc *pt) 2727 { > 2728 return page_to_virt(ptdesc_page(pt)); 2729 } 2730 2731 static inline void *ptdesc_address(struct ptdesc *pt) 2732 { > 2733 return folio_address(ptdesc_folio(pt)); 2734 } 2735 2736 static inline bool ptdesc_is_reserved(struct ptdesc *pt) 2737 { > 2738 return folio_test_reserved(ptdesc_folio(pt)); 2739 } 2740 2741 static inline struct ptdesc *ptdesc_alloc(gfp_t gfp, unsigned int order) 2742 { 2743 struct page *page = alloc_pages(gfp | __GFP_COMP, order); 2744 2745 return page_ptdesc(page); 2746 } 2747 2748 static inline void ptdesc_free(struct ptdesc *pt) 2749 { > 2750 struct page *page = ptdesc_page(pt); 2751 2752 __free_pages(page, compound_order(page)); 2753 } 2754 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests