Re: [PATCH] Fix J-core aic warning spam

Hi Rob!

On Mon, 2023-04-17 at 23:23 -0500, Rob Landley wrote:
> From: Rich Felker <[email protected]>
> Signed-off-by: Rob Landley <[email protected]>
> 
> Silence noisy boot messages (warning and stack dump for each IRQ) when booting
> on J2 SOC.
> 
> ---
>  drivers/irqchip/irq-jcore-aic.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-jcore-aic.c b/drivers/irqchip/irq-jcore-aic.c
> index 5f47d8ee4ae3..730252cb7b08 100644
> --- a/drivers/irqchip/irq-jcore-aic.c
> +++ b/drivers/irqchip/irq-jcore-aic.c
> @@ -68,6 +68,7 @@ static int __init aic_irq_of_init(struct device_node *node,
>  	unsigned min_irq = JCORE_AIC2_MIN_HWIRQ;
>  	unsigned dom_sz = JCORE_AIC_MAX_HWIRQ+1;
>  	struct irq_domain *domain;
> +	int rc;
> 
>  	pr_info("Initializing J-Core AIC\n");
> 
> @@ -100,6 +101,11 @@ static int __init aic_irq_of_init(struct device_node *node,
>  	jcore_aic.irq_unmask = noop;
>  	jcore_aic.name = "AIC";
> 
> +	rc = irq_alloc_descs(min_irq, min_irq, dom_sz - min_irq,
> +			     of_node_to_nid(node));
> +	if (rc < 0)
> +		pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
> +			min_irq);
>  	domain = irq_domain_add_legacy(node, dom_sz - min_irq, min_irq, min_irq,
>  				       &jcore_aic_irqdomain_ops,
>  				       &jcore_aic);

This more looks like it's adding a missing call to irc_alloc_descs() rather than
silencing kernel messages. The latter would be a brushing over of an error while
the former would fix the actual problem, wouldn't it?

So, I think the patch title might be misleading.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913