Re: [PATCH] Fix J-core aic warning spam

Hi Adrian, Rob,

On Tue, Apr 18, 2023 at 8:19 AM John Paul Adrian Glaubitz
<[email protected]> wrote:
> On Mon, 2023-04-17 at 23:23 -0500, Rob Landley wrote:
> > From: Rich Felker <[email protected]>
> > Signed-off-by: Rob Landley <[email protected]>
> >
> > Silence noisy boot messages (warning and stack dump for each IRQ) when booting
> > on J2 SOC.

> > --- a/drivers/irqchip/irq-jcore-aic.c
> > +++ b/drivers/irqchip/irq-jcore-aic.c
> > @@ -68,6 +68,7 @@ static int __init aic_irq_of_init(struct device_node *node,
> >       unsigned min_irq = JCORE_AIC2_MIN_HWIRQ;
> >       unsigned dom_sz = JCORE_AIC_MAX_HWIRQ+1;
> >       struct irq_domain *domain;
> > +     int rc;
> >
> >       pr_info("Initializing J-Core AIC\n");
> >
> > @@ -100,6 +101,11 @@ static int __init aic_irq_of_init(struct device_node *node,
> >       jcore_aic.irq_unmask = noop;
> >       jcore_aic.name = "AIC";
> >
> > +     rc = irq_alloc_descs(min_irq, min_irq, dom_sz - min_irq,
> > +                          of_node_to_nid(node));
> > +     if (rc < 0)
> > +             pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
> > +                     min_irq);

This is a fatal error, so please bail out, instead of continuing.

> >       domain = irq_domain_add_legacy(node, dom_sz - min_irq, min_irq, min_irq,
> >                                      &jcore_aic_irqdomain_ops,
> >                                      &jcore_aic);
>
> This more looks like it's adding a missing call to irc_alloc_descs() rather than
> silencing kernel messages. The latter would be a brushing over of an error while
> the former would fix the actual problem, wouldn't it?
>
> So, I think the patch title might be misleading.

Indeed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds