Re: [PATCH] Fix J-core aic warning spam

On 4/18/23 01:13, John Paul Adrian Glaubitz wrote:
> Hi Rob!
> 
> On Mon, 2023-04-17 at 23:23 -0500, Rob Landley wrote:
>> From: Rich Felker <[email protected]>
>> Signed-off-by: Rob Landley <[email protected]>
>> 
>> Silence noisy boot messages (warning and stack dump for each IRQ) when booting
>> on J2 SOC.
>>
>> ---
>>  drivers/irqchip/irq-jcore-aic.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/drivers/irqchip/irq-jcore-aic.c b/drivers/irqchip/irq-jcore-aic.c
>> index 5f47d8ee4ae3..730252cb7b08 100644
>> --- a/drivers/irqchip/irq-jcore-aic.c
>> +++ b/drivers/irqchip/irq-jcore-aic.c
>> @@ -68,6 +68,7 @@ static int __init aic_irq_of_init(struct device_node *node,
>>  	unsigned min_irq = JCORE_AIC2_MIN_HWIRQ;
>>  	unsigned dom_sz = JCORE_AIC_MAX_HWIRQ+1;
>>  	struct irq_domain *domain;
>> +	int rc;
>> 
>>  	pr_info("Initializing J-Core AIC\n");
>> 
>> @@ -100,6 +101,11 @@ static int __init aic_irq_of_init(struct device_node *node,
>>  	jcore_aic.irq_unmask = noop;
>>  	jcore_aic.name = "AIC";
>> 
>> +	rc = irq_alloc_descs(min_irq, min_irq, dom_sz - min_irq,
>> +			     of_node_to_nid(node));
>> +	if (rc < 0)
>> +		pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
>> +			min_irq);
>>  	domain = irq_domain_add_legacy(node, dom_sz - min_irq, min_irq, min_irq,
>>  				       &jcore_aic_irqdomain_ops,
>>  				       &jcore_aic);
> 
> This more looks like it's adding a missing call to irc_alloc_descs() rather than
> silencing kernel messages. The latter would be a brushing over of an error while
> the former would fix the actual problem, wouldn't it?
> 
> So, I think the patch title might be misleading.

Rich never bothered to explain what he was doing:

http://git.musl-libc.org/cgit/linux-sh/commit/?h=v5.16%2bj2&id=beb1f3ae8ad60f851c5920c89ad0386fbf8c3473

At a quick glance it looks like the right fix to me (thus not a hack).

The lack of explanation is more pronounced in some of his other patches:

http://git.musl-libc.org/cgit/linux-sh/commit/?h=v5.16%2bj2&id=9b22e72e623edfb57046cf61edfa0762f0e8bc13

What actual problem is that trying to address? No idea. I don't seem to have hit
it, whatever it is, so didn't try to submit that anywhere.

These three:

http://git.musl-libc.org/cgit/linux-sh/commit/?h=v5.16%2bj2&id=4c7333b0fb9e
http://git.musl-libc.org/cgit/linux-sh/commit/?h=v5.16%2bj2&id=53ac9fc75ae0
http://git.musl-libc.org/cgit/linux-sh/commit/?h=v5.16%2bj2&id=262e1e5884da

Can _probably_ go upstream as is, but after my last round of such I still
haven't replied to Andrew Morton's

  https://lkml.iu.edu/hypermail/linux/kernel/2302.2/08040.html

Because

  https://landley.net/notes.html#22-02-2023
  https://landley.net/notes.html#24-02-2023

I've got another one since [attached] but the last time I pushed a one line
"removal of leftover debris in a header" obvious cleanup patch was
https://lkml.iu.edu/hypermail/linux/kernel/1603.2/00054.html and multiplying the
amount of explanation I had to do _then_ with 7 more years of continuing kernel
community ossification ala
https://web.archive.org/web/20200629223507/https://www.zdnet.com/article/linus-torvalds-looks-at-the-future-of-linux-kernel-developers-and-development/#:~:text=ages
and I expect getting that in to require an hour-long video presentation with
diagrams, and I am SO tired.

> Adrian

Rob

From: Rob Landley <[email protected]>
Subject: [PATCH] Remove stale NCP entry (leftover from bd32895c750b)
Date: Tue, 17 Apr 2023 07:29:09 _+0900

Commit 1bb8155080c6 moved ncpfs (Novell netware) into drivers/staging
and commit bd32895c750b deleted it. But they left it in the header...

---
diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
index 6325d1d0e90f..91d52a7e9770 100644
--- a/include/uapi/linux/magic.h
+++ b/include/uapi/linux/magic.h
@@ -46,7 +46,6 @@
 
 #define MSDOS_SUPER_MAGIC	0x4d44		/* MD */
 #define EXFAT_SUPER_MAGIC	0x2011BAB0
-#define NCP_SUPER_MAGIC		0x564c		/* Guess, what 0x564c is :-) */
 #define NFS_SUPER_MAGIC		0x6969
 #define OCFS2_SUPER_MAGIC	0x7461636f
 #define OPENPROM_SUPER_MAGIC	0x9fa1