Re: [PATCH] Fix J-core aic warning spam

On 4/18/23 03:56, Sergey Shtylyov wrote:
> On 4/18/23 10:18 AM, Geert Uytterhoeven wrote:
> [...]
>>>> From: Rich Felker <[email protected]>
>>>> Signed-off-by: Rob Landley <[email protected]>
>>>>
>>>> Silence noisy boot messages (warning and stack dump for each IRQ) when booting
>>>> on J2 SOC.
>> 
>>>> --- a/drivers/irqchip/irq-jcore-aic.c
>>>> +++ b/drivers/irqchip/irq-jcore-aic.c
> [...]
>>>> @@ -100,6 +101,11 @@ static int __init aic_irq_of_init(struct device_node *node,
>>>>       jcore_aic.irq_unmask = noop;
>>>>       jcore_aic.name = "AIC";
>>>>
>>>> +     rc = irq_alloc_descs(min_irq, min_irq, dom_sz - min_irq,
>>>> +                          of_node_to_nid(node));
>>>> +     if (rc < 0)
>>>> +             pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
>>>> +                     min_irq);
>> 
>> This is a fatal error, so please bail out, instead of continuing.
> 
>    Then shounld't we use pr_err() (or stronger), not pr_info()?

That I agree with. Happy to repost the patch with that? (Or, you could just sed
's/pr_info/pr_err/' file.patch at your end if that's easier...)

Rob