Re: [PATCH v3 00/19] arch: Consolidate <asm/fb.h>
Helge Deller <[email protected]>
| Newsgroups | gmane.linux.ports.ia64,gmane.linux.kernel.cross-arch,gmane.linux.ports.parisc,gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.ports.mips,gmane.linux.ports.sparc,gmane.linux.kernel.arc,gmane.linux.ports.ppc64.devel,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Thomas,
> Am 17.04.23 um 16:12 schrieb Arnd Bergmann:>> On Mon, Apr 17, 2023, at 14:56, Thomas Zimmermann wrote:
>>> Various architectures provide <asm/fb.h> with helpers for fbdev
>>> framebuffer devices. Share the contained code where possible. There
>>> is already <asm-generic/fb.h>, which implements generic (as in
>>> 'empty') functions of the fbdev helpers. The header was added in
>>> commit aafe4dbed0bf ("asm-generic: add generic versions of common
>>> headers"), but never used.
>>>
>>> Each per-architecture header file declares and/or implements fbdev
>>> helpers and defines a preprocessor token for each. The generic
>>> header then provides the remaining helpers. It works like the I/O
>>> helpers in <asm/io.h>.
>>
>> Looks all good to me,
>>
>> Acked-by: Arnd Bergmann <[email protected]>
>
> Thanks a lot. I know that Helge wants to test the PARISC changes, so
> I'll keep this series pending for a bit longer. I'd like to merge the
> patches through the DRM tree, if no one objects.
Yes, patch is good and I've tested it on parisc. Thanks!
You may add:
Acked-by: Helge Deller <[email protected]>
to the series and take it through the drm tree.
Helge