Re: [PATCH] Remove HAVE_VIRT_CPU_ACCOUNTING_GEN option

On Sun Apr 30, 2023 at 6:14 AM AEST, Palmer Dabbelt wrote:
> On Fri, 28 Apr 2023 23:33:48 PDT (-0700), [email protected] wrote:
> > This option was created in commit 554b0004d0ec4 ("vtime: Add
> > HAVE_VIRT_CPU_ACCOUNTING_GEN Kconfig") for architectures to indicate
> > they support the 64-bit cputime_t required for VIRT_CPU_ACCOUNTING_GEN.
> >
> > The cputime_t type has since been removed, so this doesn't have any
> > meaning. Remove it.
> >
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: Vineet Gupta <[email protected]>
> > Cc: [email protected]
> > Cc: Brian Cain <[email protected]>
> > Cc: [email protected]
> > Cc: Huacai Chen <[email protected]>
> > Cc: [email protected]
> > Cc: Geert Uytterhoeven <[email protected]>
> > Cc: [email protected]
> > Cc: Michal Simek <[email protected]>
> > Cc: Thomas Bogendoerfer <[email protected]>
> > Cc: [email protected]
> > Cc: Dinh Nguyen <[email protected]>
> > Cc: Jonas Bonn <[email protected]>
> > Cc: Stefan Kristiansson <[email protected]>
> > Cc: Stafford Horne <[email protected]>
> > Cc: [email protected]
> > Cc: "James E.J. Bottomley" <[email protected]>
> > Cc: Helge Deller <[email protected]>
> > Cc: [email protected]
> > Cc: Paul Walmsley <[email protected]>
> > Cc: Palmer Dabbelt <[email protected]>
> > Cc: Albert Ou <[email protected]>
> > Cc: [email protected]
> > Cc: Yoshinori Sato <[email protected]>
> > Cc: Rich Felker <[email protected]>
> > Cc: John Paul Adrian Glaubitz <[email protected]>
> > Cc: [email protected]
> > Cc: "David S. Miller" <[email protected]>
> > Cc: [email protected]
> > Cc: Richard Weinberger <[email protected]>
> > Cc: Anton Ivanov <[email protected]>
> > Cc: Johannes Berg <[email protected]>
> > Cc: [email protected]
> > Cc: Thomas Gleixner <[email protected]>
> > Cc: Ingo Molnar <[email protected]>
> > Cc: Borislav Petkov <[email protected]>
> > Cc: Dave Hansen <[email protected]>
> > Cc: [email protected]
> > Cc: "H. Peter Anvin" <[email protected]>
> > Cc: Kevin Hilman <[email protected]>
> > Cc: Frederic Weisbecker <[email protected]>
> > Signed-off-by: Nicholas Piggin <[email protected]>
> > ---
> > Hi,
> >
> > Could we tidy this? I don't know what tree it can go in, timers,
> > sched, asm-generic, probably doesn't matter.
> >
> > The only thing this actually does is gate VIRT_CPU_ACCOUNTING_GEN and
> > NO_HZ_FULL so if your arch has some other issue that requires this
> > then the documentation needs to change. Any concerns from the archs?
> > I.e., 32-bit that does *not* define HAVE_VIRT_CPU_ACCOUNTING_GEN
> > which looks to be:
> >
> > arc
> > hexagon
> > loongarch 32-bit with SMP
> > m68k
> > microblaze
> > mips 32-bit with SMP
> > nios2
> > openrisc
> > parisc 32-bit
> > riscv 32-bit
>
> Nothing's jumping out, though I haven't tested this yet so I'm not 100%.  
> I assume this isn't aimed for this merge window, given the timing?  

No, maybe the next one though.

> Probably best to give this sort of thing time to bake in linux-next, but 
> I doubt anyone is even paying attention to rv32/NO_HZ_FULL so no big 
> deal either way on my end.
>
> Acked-by: Palmer Dabbelt <[email protected]> # RISC-V

Thanks,
Nick