Re: [PATCH 2/2] sh: dma: Correct the number of DMA channels in SH7709
John Paul Adrian Glaubitz <[email protected]>
| Newsgroups | gmane.linux.ports.sh.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <c630350f51eb3bf85d2a7fb7c51b3f1ba3a57c4f.camel@physik.fu-berlin.de> |
On Sat, 2023-05-06 at 16:17 +0200, Artur Rojek wrote: > According to the PM, the DMAC found in SH7709 features only 4 channels. > > Signed-off-by: Artur Rojek <[email protected]> > --- > arch/sh/drivers/dma/Kconfig | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/sh/drivers/dma/Kconfig b/arch/sh/drivers/dma/Kconfig > index 7d54f284ce10..4494d09597e9 100644 > --- a/arch/sh/drivers/dma/Kconfig > +++ b/arch/sh/drivers/dma/Kconfig > @@ -28,8 +28,9 @@ config SH_DMA_API > config NR_ONCHIP_DMA_CHANNELS > int > depends on SH_DMA > - default "4" if CPU_SUBTYPE_SH7750 || CPU_SUBTYPE_SH7751 || \ > - CPU_SUBTYPE_SH7750S || CPU_SUBTYPE_SH7091 > + default "4" if CPU_SUBTYPE_SH7709 || CPU_SUBTYPE_SH7750 || \ > + CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7750S || \ > + CPU_SUBTYPE_SH7091 > default "8" if CPU_SUBTYPE_SH7750R || CPU_SUBTYPE_SH7751R || \ > CPU_SUBTYPE_SH7760 > default "12" if CPU_SUBTYPE_SH7723 || CPU_SUBTYPE_SH7780 || \ > @@ -37,8 +38,9 @@ config NR_ONCHIP_DMA_CHANNELS > default "6" > help > This allows you to specify the number of channels that the on-chip > - DMAC supports. This will be 4 for SH7750/SH7751/Sh7750S/SH7091 and 8 for the > - SH7750R/SH7751R/SH7760, 12 for the SH7723/SH7780/SH7785/SH7724, default is 6. > + DMAC supports. This will be 4 for SH7709/SH7750/SH7751/Sh7750S/SH7091 > + and 8 for the SH7750R/SH7751R/SH7760, 12 for the SH7723/SH7780/SH7785/SH7724, > + default is 6. > > config SH_DMABRG > bool "SH7760 DMABRG support" I will replace "PM" with "processor manual" since the acronym is not necessarily unambiguous, at least I didn't know at first what you were referring to. I checked the manual [1] myself and four DMA channels is correct, thus: Reviewed-by: John Paul Adrian Glaubitz <[email protected]> Adrian > [1] https://www.renesas.com/us/en/document/mah/sh7709s-group-hardware-manual?r=1055106 (S. 373) -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913