Re: [PATCH 1/2] sh: dma: fix `dmaor_read_reg`/`dmaor_write_reg` macros
John Paul Adrian Glaubitz <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.ports.sh.devel |
|---|---|
| Message-ID | <3687ad9134f6869a479b94f821f92aefd41bd449.camel@physik.fu-berlin.de> |
Hi Geert! On Mon, 2023-05-08 at 13:20 +0200, Geert Uytterhoeven wrote: > Looks like this is still broken on e.g. SH7751R, which has 8 channels, > both handled by a single DMAOR register at offset 0x40... > > While e.g. dma_base_addr() seems to have some provision for this > (cfr. the "chan >= 9" (not "8") check), dma_find_base() will fail, as > arch/sh/include/cpu-sh4/cpu/dma.h defines SH_DMAC_BASE1. > Anyway, that's not new, so I have no objection to your patch. Was SH7751R broken by 7f47c7189b3e8f19 as well? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913