Re: [PATCH 10/14] suspend: add a arch_resume_nosmt() prototype
"Rafael J. Wysocki" <[email protected]>
| Newsgroups | gmane.linux.ports.parisc,gmane.linux.kernel.mm,gmane.linux.ports.arm.kernel,gmane.linux.kernel,gmane.linux.ports.mips,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.power-management.general |
|---|---|
| Message-ID | <CAJZ5v0h+HNTMcfxFuOeO92D__NzJSTHfjzP5VQG4D+WuNmHpdw@mail.gmail.com> |
On Wed, May 17, 2023 at 4:52 PM Arnd Bergmann <[email protected]> wrote: > > On Wed, May 17, 2023, at 15:48, Rafael J. Wysocki wrote: > > On Wed, May 17, 2023 at 3:12 PM Arnd Bergmann <[email protected]> wrote: > >> > >> From: Arnd Bergmann <[email protected]> > >> > >> The arch_resume_nosmt() has a __weak definition, plus an x86 > >> specific override, but no prototype that ensures the two have > >> the same arguments. This causes a W=1 warning: > >> > >> arch/x86/power/hibernate.c:189:5: error: no previous prototype for 'arch_resume_nosmt' [-Werror=missing-prototypes] > >> > >> Add the prototype in linux/suspend.h, which is included in > >> both places. > >> > >> Signed-off-by: Arnd Bergmann <[email protected]> > > > > Do you want me to pick this up? > > Yes, please do. Thanks, Done, thanks!