Re: [PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev
Javier Martinez Canillas <[email protected]>
| Newsgroups | gmane.linux.ports.arm.omap,gmane.comp.video.dri.devel,gmane.linux.ports.sh.devel |
|---|---|
| Message-ID | <[email protected]> |
Thomas Zimmermann <[email protected]> writes: > Do not assing the Linux device to struct fb_info.dev. The call to > register_framebuffer() initializes the field to the fbdev device. > Drivers should not override its value. > > Fixes a bug where the driver incorrectly decreases the hardware > device's reference counter and leaks the fbdev device. > > Signed-off-by: Thomas Zimmermann <[email protected]> > --- Reviewed-by: Javier Martinez Canillas <[email protected]> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat