Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device
Daniel Thompson <[email protected]>
| Newsgroups | gmane.linux.ports.arm.omap,gmane.comp.video.dri.devel,gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.linux.kernel.stable |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote:
> Struct bd6107_platform_data refers to a platform device within
> the Linux device hierarchy. The test in bd6107_backlight_check_fb()
> compares it against the fbdev device in struct fb_info.dev, which
> is different. Fix the test by comparing to struct fb_info.device.
>
> Fixes a bug in the backlight driver and prepares fbdev for making
> struct fb_info.dev optional.
>
> v2:
> * move renames into separate patch (Javier, Sam, Michael)
>
> Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: Daniel Thompson <[email protected]>
> Cc: Jingoo Han <[email protected]>
> Cc: [email protected]
> Cc: <[email protected]> # v3.12+
> Reviewed-by: Javier Martinez Canillas <[email protected]>
Reviewed-by: Daniel Thompson <[email protected]>
Daniel.
PS Please don't treat this as an Acked-by, if you want to land this
patchset via a single tree please coordinate with Lee Jones!