Re: [PATCH v3 01/38] backlight/bd6107: Compare against struct fb_info.device

Thomas Zimmermann <[email protected]>
Newsgroups gmane.linux.ports.sh.devel,gmane.comp.video.dri.devel,gmane.linux.ports.arm.omap,gmane.linux.kernel,gmane.linux.kernel.stable
Message-ID <[email protected]>
Hi

Am 14.06.23 um 15:51 schrieb Lee Jones:
> On Tue, 13 Jun 2023, Thomas Zimmermann wrote:
> 
>> Struct bd6107_platform_data refers to a platform device within
>> the Linux device hierarchy. The test in bd6107_backlight_check_fb()
>> compares it against the fbdev device in struct fb_info.dev, which
>> is different. Fix the test by comparing to struct fb_info.device.
>>
>> Fixes a bug in the backlight driver and prepares fbdev for making
>> struct fb_info.dev optional.
>>
>> v2:
>> 	* move renames into separate patch (Javier, Sam, Michael)
>>
>> Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
>> Signed-off-by: Thomas Zimmermann <[email protected]>
>> Cc: Laurent Pinchart <[email protected]>
>> Cc: Lee Jones <[email protected]>
>> Cc: Daniel Thompson <[email protected]>
>> Cc: Jingoo Han <[email protected]>
>> Cc: [email protected]
>> Cc: <[email protected]> # v3.12+
>> Reviewed-by: Javier Martinez Canillas <[email protected]>
>> Reviewed-by: Sam Ravnborg <[email protected]>
>> Reviewed-by: Daniel Thompson <[email protected]>
>> ---
>>   drivers/video/backlight/bd6107.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Can the Backlight patches be applied without the others and visa versa?

Unfortunately not. The rest of the series requires the backlight patches.

Best regards
Thomas

> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
OpenPGP_signature (application/pgp-signature, 840 B) - not displayed
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.