Re: [PATCH] sh: Replace all non-returning strlcpy with strscpy
Kees Cook <[email protected]>
| Newsgroups | gmane.linux.ports.sh.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 30 May 2023 16:30:41 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]
Build tested with sh4 GCC 13.1 from:
https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.1.0/
with defconfig and:
CONFIG_CPU_SUBTYPE_SH7343=y
CONFIG_SH_DMA=y
CONFIG_SH_DMA_API=y
Applied to for-next/hardening, thanks!
[1/1] sh: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/ca64da3052be
--
Kees Cook