Re: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier
"Edgecombe, Rick P" <[email protected]>
| Newsgroups | gmane.linux.ports.sparc,gmane.linux.kernel,gmane.linux.ports.ia64,gmane.linux.ports.sh.devel,gmane.linux.uml.devel,gmane.linux.ports.arm.kernel,gmane.linux.ports.mips |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote: > Fortunately none of the init calls between calibrate_delay() and > arch_cpu_finalize_init() is relevant for the functionality of > arch_cpu_finalize_init(). > Reviewed-by: Rick Edgecombe <[email protected]> I did my best to find a counterpoint to this statement. The only thing I found was that lockdep_init_task(&init_task) in fork_init() is now called after the spin_lock() usage in set_memory_4k(). But AFAICT, that whole lockdep_init_task() call is unneeded because the fields it sets are already statically initialized. I mention only because I'm not 100% sure the lockdep_init_task() call is not serving some purpose I'm missing.