Re: [v3,17/19] arch/sparc: Implement fb_is_primary_device() in source file
"Arnd Bergmann" <[email protected]>
| Newsgroups | gmane.linux.ports.m68k,gmane.linux.kernel.cross-arch,gmane.linux.ports.ia64,gmane.linux.ports.parisc,gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.comp.video.dri.devel,gmane.linux.ports.mips,gmane.linux.ports.sparc,gmane.linux.kernel.arc,gmane.linux.ports.ppc64.devel,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Jun 24, 2023, at 03:55, Guenter Roeck wrote: > > On Mon, Apr 17, 2023 at 02:56:49PM +0200, Thomas Zimmermann wrote: >> Other architectures implment fb_is_primary_device() in a source >> file. Do the same on sparc. No functional changes, but allows to >> remove several include statement from <asm/fb.h>. >> >> v2: >> * don't include <asm/prom.h> in header file >> >> Signed-off-by: Thomas Zimmermann <[email protected]> >> Cc: "David S. Miller" <[email protected]> > > This patch results (or appears to result) in the following build error > when trying to build sparc64:allmodconfig. > > Error log: > <stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] > WARNING: modpost: drivers/cpufreq/sparc-us2e-cpufreq: section mismatch > in reference: cpufreq_us2e_driver+0x20 (section: .data) -> > us2e_freq_cpu_init (section: .init.text) > WARNING: modpost: drivers/cpufreq/sparc-us3-cpufreq: section mismatch > in reference: cpufreq_us3_driver+0x20 (section: .data) -> > us3_freq_cpu_init (section: .init.text) > ERROR: modpost: "__xchg_called_with_bad_pointer" [lib/atomic64_test.ko] > undefined! These all look like old bugs that would be trivially fixed if anyone cared about sparc. > ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o I checked that there are no callers of fb_is_primary_device() in built-in code when CONFIG_FB is =m, so adding the MODULE_LICENSE() and MODULE_DESCRIPTION() tags to the file is the correct fix. Arnd