Re: [PATCH v3 06/19] arch/loongarch: Implement <asm/fb.h> with generic helpers
WANG Xuerui <[email protected]>
| Newsgroups | gmane.linux.ports.m68k,gmane.linux.kernel.cross-arch,gmane.comp.video.dri.devel,gmane.linux.kernel.arc,gmane.linux.kernel,gmane.linux.ports.arm.kernel,gmane.linux.ports.ia64,gmane.linux.ports.mips,gmane.linux.ports.parisc,gmane.linux.ports.ppc64.devel,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc |
|---|---|
| Message-ID | <[email protected]> |
Hi, On 2023/4/17 20:56, Thomas Zimmermann wrote: > Replace the architecture's fbdev helpers with the generic > ones from <asm-generic/fb.h>. No functional changes. > > v2: > * use default implementation for fb_pgprotect() (Arnd) > > Signed-off-by: Thomas Zimmermann <[email protected]> > Cc: Huacai Chen <[email protected]> > Cc: WANG Xuerui <[email protected]> > --- > arch/loongarch/include/asm/fb.h | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/arch/loongarch/include/asm/fb.h b/arch/loongarch/include/asm/fb.h > index 3116bde8772d..ff82f20685c8 100644 > --- a/arch/loongarch/include/asm/fb.h > +++ b/arch/loongarch/include/asm/fb.h > @@ -5,19 +5,6 @@ > #ifndef _ASM_FB_H_ > #define _ASM_FB_H_ > > -#include <linux/fb.h> > -#include <linux/fs.h> > -#include <asm/page.h> > - > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > - unsigned long off) > -{ > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > -} > - > -static inline int fb_is_primary_device(struct fb_info *info) > -{ > - return 0; > -} > +#include <asm-generic/fb.h> > > #endif /* _ASM_FB_H_ */ Sorry for the late review. The change is fairly trivial, so: Reviewed-by: WANG Xuerui <[email protected]> Thanks! -- WANG "xen0n" Xuerui Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/