[PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver
Thomas Zimmermann <[email protected]>
| Newsgroups | gmane.comp.freedesktop.amd-gfx,gmane.comp.emulators.kvm.devel,gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.linux.ports.geode,gmane.comp.video.dri.devel,gmane.linux.kernel.input,gmane.linux.ports.arm.omap,gmane.linux.ports.ppc64.devel,gmane.linux.ports.arm.kernel,gmane.linux.drivers.video-input-infrastructure |
|---|---|
| Message-ID | <[email protected]> |
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. Signed-off-by: Thomas Zimmermann <[email protected]> Cc: "Bruno Prémont" <bonbons-ud5FBsm0p/xEiooADzr8i9i2O/[email protected]> Cc: Jiri Kosina <[email protected]> Cc: Benjamin Tissoires <[email protected]> --- drivers/hid/hid-picolcd_fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c index dabcd054dad9..d726aaafb146 100644 --- a/drivers/hid/hid-picolcd_fb.c +++ b/drivers/hid/hid-picolcd_fb.c @@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data) info->var = picolcdfb_var; info->fix = picolcdfb_fix; info->fix.smem_len = PICOLCDFB_SIZE*8; - info->flags = FBINFO_FLAG_DEFAULT; fbdata = info->par; spin_lock_init(&fbdata->lock); -- 2.41.0