Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver

Benjamin Tissoires <[email protected]> Mon, 10 Jul 2023 15:05:19 +0200

Newsgroups	gmane.linux.ports.arm.omap,gmane.linux.ports.sh.devel,gmane.comp.video.dri.devel,gmane.linux.kernel,gmane.comp.freedesktop.amd-gfx,gmane.linux.kernel.input,gmane.linux.drivers.video-input-infrastructure,gmane.linux.ports.arm.kernel,gmane.linux.ports.geode,gmane.linux.ports.ppc64.devel,gmane.comp.emulators.kvm.devel
Message-ID	<CAO-hwJLvBpNu1z4qM9+331-oUroh4g5HORL=EZS0nb+HHe+fdw@mail.gmail.com>

On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann <[email protected]> wrote:
>
> The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
> fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
> not set it.
>
> Flags should signal differences from the default values. After cleaning
> up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
>
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Cc: "Bruno Prémont" <[email protected]>
> Cc: Jiri Kosina <[email protected]>
> Cc: Benjamin Tissoires <[email protected]>

Acked-by: Benjamin Tissoires <[email protected]>

Feel free to take this through the DRI tree (or any other that handles
FB) with the rest of the series if you want.

Cheers,
Benjamin

> ---
>  drivers/hid/hid-picolcd_fb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index dabcd054dad9..d726aaafb146 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data)
>         info->var = picolcdfb_var;
>         info->fix = picolcdfb_fix;
>         info->fix.smem_len   = PICOLCDFB_SIZE*8;
> -       info->flags = FBINFO_FLAG_DEFAULT;
>
>         fbdata = info->par;
>         spin_lock_init(&fbdata->lock);
> --
> 2.41.0
>