Re: [PATCH 08/17] arch/sh: Do not assign FBINFO_FLAG_DEFAULT to fb_videomode.flag

John Paul Adrian Glaubitz <[email protected]> Mon, 10 Jul 2023 15:59:35 +0200

Newsgroups	gmane.linux.kernel.input,gmane.linux.ports.sh.devel,gmane.comp.video.dri.devel,gmane.linux.kernel,gmane.comp.freedesktop.amd-gfx,gmane.linux.drivers.video-input-infrastructure,gmane.linux.ports.arm.kernel,gmane.linux.ports.geode,gmane.linux.ports.arm.omap,gmane.linux.ports.ppc64.devel,gmane.comp.emulators.kvm.devel
Message-ID	<536cc8c679cc68829c8662176ff02a9052249a46.camel@physik.fu-berlin.de>

Hi Thomas!

On Mon, 2023-07-10 at 15:52 +0200, Thomas Zimmermann wrote:
> > I would argue that the current code is more readable that your proposed change.
> > 
> > I agree that it's a no-op, but code is not just about functionality but also
> > readability, isn't it?
> 
> I won't argue with that, but the flag itself is wrong. 
> FBINFO_FLAG_DEFAULT is/was for struct fb_info.flags. You have struct 
> fb_videomode.flag. The valid flags for this field are at [1]. If 
> anything, the field could be initialized to FB_MODE_IS_UNKNOWN, which 
> has the same value.
> 
> [1] https://elixir.bootlin.com/linux/latest/source/include/linux/fb.h#L681

FB_MODE_IS_UNKNOWN sounds very reasonable to me. Would you agree using that instead?

> > 
> > Also, I prefer "sh:" as the architecture prefix, not "arch/sh:".
> 
> Ok.

Thanks.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913