Re: [PATCH 08/17] arch/sh: Do not assign FBINFO_FLAG_DEFAULT to fb_videomode.flag

John Paul Adrian Glaubitz <[email protected]> Mon, 10 Jul 2023 16:08:05 +0200

Newsgroups	gmane.linux.ports.arm.omap,gmane.linux.ports.sh.devel,gmane.comp.video.dri.devel,gmane.linux.kernel,gmane.comp.freedesktop.amd-gfx,gmane.linux.kernel.input,gmane.linux.drivers.video-input-infrastructure,gmane.linux.ports.arm.kernel,gmane.linux.ports.geode,gmane.linux.ports.ppc64.devel,gmane.comp.emulators.kvm.devel
Message-ID	<268cf09b42a5ad6f1edb30b6d237f31174b85abb.camel@physik.fu-berlin.de>

Hi!

On Mon, 2023-07-10 at 16:04 +0200, Thomas Zimmermann wrote:
> > > I won't argue with that, but the flag itself is wrong.
> > > FBINFO_FLAG_DEFAULT is/was for struct fb_info.flags. You have struct
> > > fb_videomode.flag. The valid flags for this field are at [1]. If
> > > anything, the field could be initialized to FB_MODE_IS_UNKNOWN, which
> > > has the same value.
> > > 
> > > [1] https://elixir.bootlin.com/linux/latest/source/include/linux/fb.h#L681
> > 
> > FB_MODE_IS_UNKNOWN sounds very reasonable to me. Would you agree using that instead?
> 
> Sure, I'll update the patch accordingly.

Thanks! I'll ack the updated patch.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913