Re: [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data

Miguel Ojeda <[email protected]> Thu, 13 Jul 2023 15:21:34 +0200

Newsgroups	gmane.linux.ports.ppc.embedded,gmane.comp.emulators.kvm.devel,gmane.linux.ports.sh.devel,gmane.linux.kernel,gmane.comp.freedesktop.amd-gfx,gmane.comp.video.dri.devel,gmane.linux.kernel.input,gmane.linux.ports.arm.omap,gmane.linux.ports.geode,gmane.linux.ports.arm.kernel,gmane.linux.drivers.video-input-infrastructure
Message-ID	<CANiq72mbLmMKph8aiz4apNF9n3MtVO-nhM9rEWYApZbSVAO9Qw@mail.gmail.com>

On Thu, Jul 13, 2023 at 3:03 PM Thomas Zimmermann <[email protected]> wrote:
>
> Most fbdev drivers depend on framebuffer_alloc() to initialize the
> allocated memory to 0. Document this guarantee.
>
> Suggested-by: Miguel Ojeda <[email protected]>
> Signed-off-by: Thomas Zimmermann <[email protected]>
> Cc: Helge Deller <[email protected]>

Thanks for sending this! Maybe this would be best earlier in the
series, so that later patches make more sense (since they use the
guarantee), but it is not a big deal.

> + * aligned to sizeof(long). Both, the instance of struct fb_info and
> + * the driver private data, are cleared to zero.

I think both commas may be best omitted (but I am not a native speaker).

Reviewed-by: Miguel Ojeda <[email protected]>

Cheers,
Miguel