Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally
"Arnd Bergmann" <[email protected]>
| Newsgroups | gmane.linux.ports.hexagon,gmane.linux.kernel,gmane.linux.kernel.next,gmane.linux.ports.alpha,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.ia64,gmane.linux.ports.mips,gmane.linux.ports.sparc,gmane.linux.ports.parisc,gmane.linux.ports.sh.devel,gmane.linux.ports.riscv |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Aug 11, 2023, at 22:09, Stafford Horne wrote: > On Thu, Aug 10, 2023 at 04:19:34PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann <[email protected]> >> arch/openrisc/mm/fault.c:44:17: error: no previous prototype for 'do_page_fault' [-Werror=missing-prototypes] >> arch/openrisc/mm/tlb.c:188:13: error: no previous prototype for 'tlb_init' [-Werror=missing-prototypes] > > I'll try to get these fixed for 6.6. I was looking at them recently but did not > actually make any changes and just put on my TODO. Your series moves it up in > priority and it should be easy to get the fixes out. Thanks! Since we already have the majority of architecture maintainers stepping in to fix the warnings, I wonder if I should just drop my patch 16/17 completely and let the others handle it as well rather than shutting up the warnings. Only the asm-offsets change is really needed to compile test most of the kernel even with CONFIG_WERROR, and without that this is just some harmless output. Arnd