Re: [RESEND RFC PATCH 03/12] sh: SH4 OF support.

Hi Sato-san,

Thanks for your patch!

On Thu, Aug 31, 2023 at 5:22 AM Yoshinori Sato
<[email protected]> wrote:
> - switch generic framework in clock / PCI.

... and much more.
Please split in separate patches.

> --- a/arch/sh/kernel/cpu/clock.c
> +++ b/arch/sh/kernel/cpu/clock.c
> @@ -14,12 +14,13 @@
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/clk.h>
> +#include <linux/of.h>
>  #include <asm/clock.h>
>  #include <asm/machvec.h>
>
>  int __init clk_init(void)
>  {
> -       int ret;
> +       int ret = 0;
>
>  #ifndef CONFIG_COMMON_CLK
>         ret = arch_clk_init();

Perhaps make this whole function depend on CONFIG_COMMON_CLK,
and call sh_of_clk_init() (or of_clk_init()) directly() from time_init()?

> @@ -15,6 +15,7 @@ perf-$(CONFIG_CPU_SUBTYPE_SH7750)     := perf_event.o
>  perf-$(CONFIG_CPU_SUBTYPE_SH7750S)     := perf_event.o
>  perf-$(CONFIG_CPU_SUBTYPE_SH7091)      := perf_event.o
>
> +ifndef CONFIG_OF

CONFIG_SH_DEVICE_TREE

>  # CPU subtype setup
>  obj-$(CONFIG_CPU_SUBTYPE_SH7750)       += setup-sh7750.o
>  obj-$(CONFIG_CPU_SUBTYPE_SH7750R)      += setup-sh7750.o

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds