Re: [RESEND RFC PATCH 09/12] of: FDT vaddr support for SH.

Hi Sato-san,

On Thu, Aug 31, 2023 at 5:18 AM Yoshinori Sato
<[email protected]> wrote:
> sh using virt address in FDT.
>
> Signed-off-by: Yoshinori Sato <[email protected]>

Thanks for your patch!

> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -643,6 +643,9 @@ void __init early_init_fdt_scan_reserved_mem(void)
>                 fdt_get_mem_rsv(initial_boot_params, n, &base, &size);
>                 if (!size)
>                         break;
> +#ifdef CONFIG_SUPERH
> +               base = virt_to_phys(base);
> +#endif

I guess this is a no-go.
Why can't you use physical address, like all other platforms?

>                 memblock_reserve(base, size);
>         }
>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds