Re: [RFC PATCH 11/12] sh: target dts.

Hi Sato-san,

On Thu, Aug 31, 2023 at 6:17 PM Geert Uytterhoeven <[email protected]> wrote:
> On Wed, Aug 30, 2023 at 8:53 PM Yoshinori Sato
> <[email protected]> wrote:
> > --- /dev/null
> > +++ b/arch/sh/boot/dts/landisk.dts
> > @@ -0,0 +1,142 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Device Tree source for IO DATA DEVICE LANDISK
> > + *
> > + * Copyright 2023 Yoshinori Sato
> > + */
> > +
> > +#include <dt-bindings/interrupt-controller/sh_intc.h>
>
> You forgot to post commit d00349bf840505a0 ("sh: SH-INTC helper files")
> in ysato/sh-of-wip.

And that one needs:

--- a/include/dt-bindings/interrupt-controller/sh_intc.h
+++ b/include/dt-bindings/interrupt-controller/sh_intc.h
@@ -1,2 +1,2 @@
-#define evt2irq(evt)           (((evt) >> 5) - 16)
-#define irq2evt(irq)           (((irq) + 16) << 5)
+#define evt2irq(evt)           (((evt) >> 5))
+#define irq2evt(irq)           (((irq)) << 5)

Cfr. commit a8ac2961148e8c72 ("sh: Avoid using IRQ0 on SH3 and SH4") in v6.5.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds