Re: [RFC PATCH v2 24/30] include/dt-bindings: Add SH7750 CPG header.

On 13/09/2023 11:23, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <[email protected]>

Empty commit msgs are not acceptable.

> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

>  include/dt-bindings/clock/sh7750.h | 13 +++++++++++++

Missing vendor prefix.

>  1 file changed, 13 insertions(+)
>  create mode 100644 include/dt-bindings/clock/sh7750.h
> 
> diff --git a/include/dt-bindings/clock/sh7750.h b/include/dt-bindings/clock/sh7750.h
> new file mode 100644
> index 000000000000..88e60a9a01df
> --- /dev/null
> +++ b/include/dt-bindings/clock/sh7750.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> + *
> + * Copyright 2023 Yoshinori Sato
> + */
> +
> +#ifndef __DT_BINDINGS_CLOCK_SH7750_H__
> +#define __DT_BINDINGS_CLOCK_SH7750_H__
> +
> +#define SH7750_CPG_FCK		0
> +#define SH7750_CPG_BCK		1
> +#define SH7750_CPG_ICK		2

This should be squashed with the patch bringing bindings for this
device. It does not make sense on its own.

Best regards,
Krzysztof