Re: [RFC PATCH v2 26/30] arch/sh: RTS7751R2D Plus DeviceTree.

On 13/09/2023 11:23, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <[email protected]>


No improvements in commit msg. No improvements in subject.

> ---
>  arch/sh/boot/dts/rts7751r2dplus.dts | 124 ++++++++++++++++++++++++++++
>  1 file changed, 124 insertions(+)
>  create mode 100644 arch/sh/boot/dts/rts7751r2dplus.dts
> 
> diff --git a/arch/sh/boot/dts/rts7751r2dplus.dts b/arch/sh/boot/dts/rts7751r2dplus.dts
> new file mode 100644
> index 000000000000..a08061133841
> --- /dev/null
> +++ b/arch/sh/boot/dts/rts7751r2dplus.dts
> @@ -0,0 +1,124 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device Tree Source for the Renesas RTS7751R2D Plus
> + */
> +
> +/dts-v1/;
> +
> +#include "sh7751.dtsi"
> +
> +/ {
> +	model = "Renesas RTS7715R2D Plus";
> +	compatible = "renesas,r2dplus";

Missing bindings documentation. Incomplete compatible - missing SoC.

Sorry, but this is nowhere ready for review. There are so many trivial
issues to fix.


Best regards,
Krzysztof