Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures
"Arnd Bergmann" <[email protected]>
| Newsgroups | gmane.linux.ports.ppc.embedded,gmane.linux.kernel,gmane.linux.kernel.cross-arch,gmane.linux.ports.parisc,gmane.linux.ports.sh.devel,gmane.linux.ports.mips,gmane.linux.kernel.mm,gmane.linux.ports.alpha,gmane.linux.ports.sparc,gmane.linux.ports.hexagon |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Sep 21, 2023, at 07:04, Baoquan He wrote: > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > extension, and on ia64 with its slightly unconventional ioremap() > behavior. So remove the ioremap_uc() definition in architecutures > other than x86 and ia64. These architectures all have asm-generic/io.h > included and will have the default ioremap_uc() definition which > returns NULL. > > This changes the existing behaviour, while no need to worry about > any breakage because in the only callsite of ioremap_uc(), code > has been adjusted to eliminate the impact. Please see > atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. > > If any new invocation of ioremap_uc() need be added, please consider > using ioremap() intead or adding a ARCH specific version if necessary. > > Signed-off-by: Baoquan He <[email protected]> > Acked-by: Geert Uytterhoeven <[email protected]> > Acked-by: Michael Ellerman <[email protected]> (powerpc) > Acked-by: Helge Deller <[email protected]> # parisc > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] Acked-by: Arnd Bergmann <[email protected]>