Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map()

On Mon, Sep 25, 2023, at 09:08, Yoshinori Sato wrote:
> On Thu, 21 Sep 2023 17:52:29 +0900, Geert Uytterhoeven wrote:
>> On Thu, Sep 21, 2023 at 9:45 AM John Paul Adrian Glaubitz <[email protected]> wrote:
>> 
>> I think including Arnd's cleanups (that is, his v2) in v6.7 is fine.
>> Sato-san's series needs more work, and is easy to fix for Arnd's cleanup
>> (just provide sh_io_port_base unconditionally).
>
> For devicetree support, we have been using GENERIC_IOMAP and GENERIC_PCI_IOMAP.
> This change has no effect, so it's okay to be merged first.

Ok, thanks for confirming.

I would still suggest that you try to avoid GENERIC_IOMAP altogether
since sh has no custom inb/outb instructions and can just implement
ioport_map() to return an __iomem token that can be passed into 
readb/writeb, the same as the non-GENERIC_IOMAP version in sh does.

Ideally you can however remove the iomap.c file and the
asm-generic/iomap.h include and instead get the inline definitions
from the defaults in include/asm-generic/io.h.

    Arnd