Re: [PATCH] sh: ecovec24: Rename missed backlight field from fbdev to dev

Thomas Zimmermann <[email protected]> Mon, 25 Sep 2023 13:28:48 +0200

Newsgroups	gmane.linux.ports.sh.devel,gmane.comp.video.dri.devel,gmane.linux.kernel
Message-ID	<[email protected]>

Hi

Am 25.09.23 um 13:10 schrieb Geert Uytterhoeven:
> One instance of gpio_backlight_platform_data.fbdev was renamed, but the
> second instance was forgotten, causing a build failure:
> 
>      arch/sh/boards/mach-ecovec24/setup.c: In function ‘arch_setup’:
>      arch/sh/boards/mach-ecovec24/setup.c:1223:37: error: ‘struct gpio_backlight_platform_data’ has no member named ‘fbdev’; did you mean ‘dev’?
>       1223 |                 gpio_backlight_data.fbdev = NULL;
> 	  |                                     ^~~~~
> 	  |                                     dev
> 
> Fix this by updating the second instance.
> 
> Fixes: ed369def91c1579a ("backlight/gpio_backlight: Rename field 'fbdev' to 'dev'")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Thomas Zimmermann <[email protected]>

Sorry for missing this driver in the original patch.

Best regards
Thomas

> ---
>   arch/sh/boards/mach-ecovec24/setup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> index 3be293335de54512..7a788d44cc73496c 100644
> --- a/arch/sh/boards/mach-ecovec24/setup.c
> +++ b/arch/sh/boards/mach-ecovec24/setup.c
> @@ -1220,7 +1220,7 @@ static int __init arch_setup(void)
>   		lcdc_info.ch[0].num_modes		= ARRAY_SIZE(ecovec_dvi_modes);
>   
>   		/* No backlight */
> -		gpio_backlight_data.fbdev = NULL;
> +		gpio_backlight_data.dev = NULL;
>   
>   		gpio_set_value(GPIO_PTA2, 1);
>   		gpio_set_value(GPIO_PTU1, 1);

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

OpenPGP_signature.asc (application/pgp-signature, 840 B)