Re: [RFC PATCH v2 26/30] arch/sh: RTS7751R2D Plus DeviceTree.

Hi Sato-san,

On Mon, Oct 2, 2023 at 3:22 PM Yoshinori Sato
<[email protected]> wrote:
> On Tue, 19 Sep 2023 22:25:19 +0900,
> Geert Uytterhoeven wrote:
> > On Wed, Sep 13, 2023 at 11:24 AM Yoshinori Sato
> > <[email protected]> wrote:
> > > Signed-off-by: Yoshinori Sato <[email protected]>
> >
> > Thanks for your patch!
> >
> > > --- /dev/null
> > > +++ b/arch/sh/boot/dts/rts7751r2dplus.dts
> > > @@ -0,0 +1,124 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Device Tree Source for the Renesas RTS7751R2D Plus
> > > + */
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "sh7751.dtsi"
> >
> > #include "sh7751r.dtsi"?
> >
> > To make that work, you can create "sh7751.dtsi" that includes
> > "sh7751.dtsi" and overrides the parts that are different.
>
> The only difference between 7751 and 7751R is CPG,
> so I don't differentiate between them.
>
> Shall we write the CPG differences in sh7751r.dtsi?

Yes please.
That way the .dts board file for a board with SH7751 can include sh7751.dtsi,
and the .dts board file for a board with SH7751R can include sh7751r.dtsi.
All common parts should be put in sh7751.dtsi, to avoid duplication.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds