Re: [RFC PATCH v3 10/35] Documentation/devicetree/bindings/pci: renesas,pci-sh7751.yaml new file.

On 14/10/2023 16:53, Yoshinori Sato wrote:
> binding document for renesas,pci-sh7751.

It's still RFC, so I assume it is not ready for merging and it is not
meant to be reviewed. In case it is not correct - some people actually
expect RFC to be merged - trivial comments:

1. Please use subject prefixes matching the subsystem. You can get them
for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
directory your patch is touching.

2. Drop final full stop from subject.

3. Missing commit msg

> 
> Signed-off-by: Yoshinori Sato <[email protected]>
> ---
>  .../bindings/pci/renesas,pci-sh7751.yaml      | 123 ++++++++++++++++++
>  1 file changed, 123 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/renesas,pci-sh7751.yaml

If sh7751 is the name of SoC or device:
renesas,sh7751-pci.yaml

> 
> diff --git a/Documentation/devicetree/bindings/pci/renesas,pci-sh7751.yaml b/Documentation/devicetree/bindings/pci/renesas,pci-sh7751.yaml
> new file mode 100644
> index 000000000000..a6081c3de51d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/renesas,pci-sh7751.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pci/renesas,pci-sh7751.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas SH7751 PCI Host controller
> +
> +maintainers:
> +  - Yoshinori Sato <[email protected]>
> +
> +allOf:
> +  - $ref: /schemas/pci/pci-bus.yaml#
> +
> +properties:
> +  compatible:
> +    items:

You can drop items

> +      - enum:
> +          - renesas,pci-sh7751

renesas,sh7751-pci

> +
> +  reg:
> +    minItems: 3

maxItems instead

> +
> +  "#interrupt-cells":
> +    const: 1
> +
> +  "#address-cells":
> +    const: 3
> +
> +  "#size-cells":
> +    const: 2
> +
> +  ranges:
> +    description: |
> +      The PCI bus memory area and I/O area.

Drop description, just ranges: true.

....

> +
> +examples:
> +  - |
> +        pci@fe200000 {

Use 4 spaces for example indentation.


Best regards,
Krzysztof