Re: [RFC PATCH v3 18/35] drivers/tty/serial: sh-sci.c fix SH4 OF support.

Hi Sato-san,

Thanks for your patch!

On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
<[email protected]> wrote:
> - fix earlycon name.

Note that to use earlycon, you currently need to enable EXPERT.
So I propose to fix that using:

--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -658,7 +658,7 @@ config SERIAL_SH_SCI_EARLYCON
        depends on SERIAL_SH_SCI=y
        select SERIAL_CORE_CONSOLE
        select SERIAL_EARLYCON
-       default ARCH_RENESAS
+       default ARCH_RENESAS || SUPERH

 config SERIAL_SH_SCI_DMA
        bool "DMA support" if EXPERT

> - fix earlyprintk hung (NULL pointer reference).

How do you actually use earlyprintk, as SH lacks the EARLY_PRINTK
config symbol?

Looks like tglx missed that when creating commit d0380e6c3c0f6edb
("early_printk: consolidate random copies of identical code").

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds