Re: [RFC PATCH v3 24/35] include/dt-binding/interrupt-controller/sh_intc.h: renesas,sh7751-intc.h helper

Hi Sato-san,

On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
<[email protected]> wrote:
> SH7751 Interrupt controller binding helper.
>
> Signed-off-by: Yoshinori Sato <[email protected]>

Thanks for your patch!

> --- /dev/null
> +++ b/include/dt-bindings/interrupt-controller/sh_intc.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> + *
> + * SH3/4 INTC EVT - IRQ conversion
> + */
> +
> +#define evt2irq(evt)           ((evt) >> 5)
> +#define irq2evt(irq)           ((irq) << 5)

Please drop irq2evt() as it is not used, and not needed, in DTS files.

> +
> +#define IPRDEF(e, o, b)                < e o b >

Please drop this macro, it doesn't add any value.

> +#define IPRA                   0
> +#define IPRB                   4
> +#define IPRC                   8
> +#define IPRD                   12
> +#define INTPRI00               256
> +#define IPR_B12                        12
> +#define IPR_B8                 8
> +#define IPR_B4                 4
> +#define IPR_B0                 0

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds