Re: [RFC PATCH v3 24/35] include/dt-binding/interrupt-controller/sh_intc.h: renesas,sh7751-intc.h helper

On 18/10/2023 15:39, Geert Uytterhoeven wrote:
> Hi Sato-san,
> 
> On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato
> <[email protected]> wrote:
>> SH7751 Interrupt controller binding helper.
>>
>> Signed-off-by: Yoshinori Sato <[email protected]>
> 
> Thanks for your patch!
> 
>> --- /dev/null
>> +++ b/include/dt-bindings/interrupt-controller/sh_intc.h
>> @@ -0,0 +1,18 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> + *
>> + * SH3/4 INTC EVT - IRQ conversion
>> + */
>> +
>> +#define evt2irq(evt)           ((evt) >> 5)
>> +#define irq2evt(irq)           ((irq) << 5)
> 
> Please drop irq2evt() as it is not used, and not needed, in DTS files.

And we talked about this already... just like about few other things
which did not improve. This patchset is repeating the same issues over
and over again.

Please call it not RFC, but "DO NOT MERGE" or something like this.

Best regards,
Krzysztof