Re: [RFC PATCH v3 20/35] drivers/mfd: sm501 add some properties.

On Sat, 14 Oct 2023, Yoshinori Sato wrote:

> I am changing the target board of SuperH using SM501 to DeviceTree.
> This target uses platform_device to configure sm501 and sm501fb.
> In order to migrate to DeviceTree, it can now be set in properties.
> 
> Signed-off-by: Yoshinori Sato <[email protected]>
> ---
>  drivers/mfd/sm501.c           | 113 ++++++++++++++++++++++++++++++++++
>  drivers/video/fbdev/sm501fb.c |  92 +++++++++++++++++++++++++++
>  2 files changed, 205 insertions(+)

Wow!  This is a 20 year old driver.  I'm surprised to see it in use.

FYI, the driver itself seems to be in a bit of state.  It would not be
accepted in its current guise if submitted in the present.

When you submit your next revision, would you please add me to the
recipients list on the *whole set* please?

Not sure I can review this until the DT guys have rubber stamped the
binding.  Some of the proposed properties look like they'll need a
re-work; specifically 'smi,devices' which looks like a bitmap of the
devices to be enabled.

-- 
Lee Jones [李琼斯]